|
|
#1 |
![]() Join Date: Jul 2004
Posts: 108
![]() |
i've been developing a mambo site + custom component for my employer, and i've been using cvs 4.5.x exports during the development process, and i want to say you guys are doing a good job. i've only had the site break once (it appears some changes were implemented for user management?), but i was able to reinstall easily enough
i'm very glad i've been using the 4.5.x cvs though, because there are some nice features that you've added in (such as with mosDBTable) that i would have missed otherwise, and they've been very useful in the development of our custom component cheers |
|
|
|
|
#2 |
![]() Join Date: Feb 2005
Posts: 11
![]() |
I second that. Great job guys! I've spent the last few weeks on a set of components, modules, and mambots that work together and allow the user to view organizational data records (companies, etc.). The component allows you to mange a view org data, while the mambots and modules allow you to embedd the same info either inside content or attached to website sections.
To make all this work in concert I've had to make some minor tweaks in Mambo itself. For instance, the code that generates and manages the checkboxes (CheckedOutProcessing) in the lists that are displayed in the adminitrator section of a component assumes that every db table uses the field 'id' as a unique record id. My tables (which I'm getting from the client) are using a different field name (e.g. 'rec_id'), so I simply changed the code for that one function to handle custom names or default to 'id' if no custom name is given. Here is the code for the changes to CheckedOutProcessing in mambo.php (RED/BOLD highlights my changes): Code:
function CheckedOutProcessing( &$row, $i, $key = 'id' ) {
global $my;
if ( $row->checked_out ) {
$checked = mosCommonHTML::checkedOut( $row );
} else {
$checked = mosHTML::idBox( $i, $row->$key, ($row->checked_out && $row->checked_out != $my->id ) );
}
return $checked[html];
}
Thanks again ... -martin.
__________________
-- coding in circles. |
|
|
|
|
#3 |
![]() Join Date: Jul 2004
Posts: 108
![]() |
you're correct that it assumes 'id' by default, which annoyed me at first, but there's ways to work around that in your component code (none of my tables have the usual 'id' field, though i've contemplated changing to it for simplicity)
have you submitted your change to the tracker? |
|
|
|
|
#4 |
![]() Join Date: Feb 2005
Posts: 11
![]() |
RE: work-around in component code
I know, but I thought this was such an easy tweak and I also thought that I probably wasn't the only with this 'issue'. Normally I'm very hesitant when it comes to changing core Mambo files, but this one offered a "lot of bang for the buck". ;-) RE: submitting change to the tracker Nope, not yet. But mostly because I haven't had a chance to figure out how to and where to do that. Can you give me hint as to how/where/when/what? TIA, -martin.
__________________
-- coding in circles. |
|
|
|
|
#5 |
![]() Join Date: Jul 2004
Posts: 108
![]() |
http://mamboforge.net/tracker/?atid=...=5&func=browse << create an account at mamboforge and submit to that tracker. you can post the code in your submission or submit it as a file
if you're experienced with CVS & file diffs, you can create a patch file (which allows them to easily merge the changes), otherwise don't worry about the patch file, lol |
|
|
|
|
#6 |
![]() Join Date: Feb 2004
Location: France
Posts: 2,188
![]() |
http://mamboforge.net/tracker/?atid=...=5&func=browse
That's also the place the upload any CMT's to if you care; so one signup prolly gets you the benefit of both submitting "bugs" (aka feature requests such as this) and setting up your project space. Sounds good ![]()
__________________
joe http://www.eyezberg.com - Flash News |
|
|
|
|
#7 |
![]() Join Date: Feb 2005
Posts: 11
![]() |
Ok. Submitted this to the tracker.
Thanks for pointing me in the right direction. -martin.
__________________
-- coding in circles. |
|
|
|
|
#8 |
![]() Join Date: Feb 2004
Location: France
Posts: 2,188
![]() |
Thanks for helping to improve
![]() To dev team: the new linkbar is really getting good, also looks good!! Don't know how many % are done, just wanted to suggest adding the respective others to installer screens (component => link to mod & bot installers; mod => link to C & B; bot => link to M&C..). Very nice feature!
__________________
joe http://www.eyezberg.com - Flash News |
|
|
|
|
#9 |
![]() Join Date: Jul 2004
Posts: 108
![]() |
i've been wondering, where is the linkbar displayed? i've noticed the new linkbar files in cvs, i haven't seen them used yet
|
|
|
|
|
#10 |
![]() Join Date: Oct 2003
Location: Marikina, Manila, Philippines
Posts: 5,153
![]() |
You need to do a clean install of CVS.
If you are testing CVS it is recommended that you regularlly do a clean install to ensure you are working with the newest possible verson of mambo as some things like the linkbar are being inserted into the Database.
__________________
All my posts are copyright © Rey Gigataras [aka stingrey] and cannot be be reproduced without permission Former Mambo Core Team Member July 2004 - August 2005 |
|
|
|
|
#11 |
![]() Join Date: Jul 2004
Posts: 108
![]() |
ah, k. i'd been trying to keep an eye on the sql file being updated, i think i must've missed it one night :-)
|
|
|
|
|
#12 |
![]() Join Date: Jul 2004
Posts: 108
![]() |
rey, idea, how about having an upgrade installer built into the admin that detects when changes/additions are made :-)
hehe... i know, it's better to just fresh install, but that would be so nice ;-) |
|
|
|
|
#13 |
![]() Join Date: Feb 2004
Location: France
Posts: 2,188
![]() |
Todays CVS has again some nice new features:
* "All content items" with a new tree menu for quick access, looks nice (tho some glitches on IE/WIN) => IMHO, this makes the 2 menu links to static/all unnecessary?! * linkbar is getting there, even if on some screens, most links do not work; * language manager display now ok on IE One suggestion, if whoever manages reads this :add the list of installed templates to the "template installer" screen, like the other installer screens..? same for languages installer?.. And many links are broken today, for ex. "site mambots" goes back the index with "You are not authorized to view this resource." message.. well, it's CVS ![]() This release is going to be fantastic!!
__________________
joe http://www.eyezberg.com - Flash News |
|
|
|
|
#14 |
![]() Join Date: Oct 2003
Location: Australia
Posts: 1,036
![]() |
Site mambots is fixed Joe.
Re installers, I'm playing with a an idea that should get you your wish. Should have it finished tomorrow.
__________________
Andrew Eddie <>< Mambo Core Developer February 2003-August 2005 http://www.jamboworks.com ... |
|
|
|
|
#15 |
![]() Join Date: Feb 2004
Location: France
Posts: 2,188
![]() |
It's always very exiting to go on a news hunt these days when Tortoise finished a longer list of updated files..
![]() I'll get some more suggestions ready and out tomorrow.
__________________
joe http://www.eyezberg.com - Flash News |
|
|
|
|
#16 |
|
Join Date: Apr 2005
Location: Germany-Berlin
Posts: 377
![]() |
The linkbar looks now really nice and is very usefull, for smaller components you can use this as your Mainmenu insteed of the use of a cpanel.
Wouldn´t it be also nice to have the option to add a small icon infront of the text? function addLink( $text, $href='', $title='' ) to function addLink( $icon='', $text, $href='', $title='' ) Just a suggestion, well maybe it could be overloaded by this extra, will check how it looks like. |
|
|
|
|
#17 |
![]() Join Date: Feb 2004
Location: France
Posts: 2,188
![]() |
Ok, here's Part Deux (2,
) of UI change suggestions: http://xaraya.free.fr/ (click on the Part 2 link obviously..)(btw, sorry to post that on a "xaraya" titled site, it's free hosting and this was a test account, tried xaraya for 2 days, lol..) Under the images, there are some details also.. Photoshop does this in just a few clicks. Icons might be nice, but nothing too fancy, just a small arrow, dot or whatever..? Or the menu icon reused..? I like Gui better than just UI personnaly G is in Graphic!
__________________
joe http://www.eyezberg.com - Flash News |
|
|
|
|
#18 | |
![]() Join Date: Oct 2003
Location: Marikina, Manila, Philippines
Posts: 5,153
![]() |
Quote:
We can look at changing image tab layout as it looks to better use the screen real estate. Dont think i'll implement the x image for Content Manager.
__________________
All my posts are copyright © Rey Gigataras [aka stingrey] and cannot be be reproduced without permission Former Mambo Core Team Member July 2004 - August 2005 |
|
|
|
|
|
#19 | |
![]() Join Date: Oct 2003
Location: Marikina, Manila, Philippines
Posts: 5,153
![]() |
Quote:
__________________
All my posts are copyright © Rey Gigataras [aka stingrey] and cannot be be reproduced without permission Former Mambo Core Team Member July 2004 - August 2005 |
|
|
|
|
|
#20 |
![]() Join Date: Feb 2004
Location: France
Posts: 2,188
![]() |
Rey,
glad you could take a look, here's another suggestion, taken from phpSurveyor, which would really rock the boat if it could find it's way into Mambo: get rid of the pop-ups, and integrate the Help directly into the screens: http://xaraya.free.fr/help_panel/ The ~closed jpg is the normal state, when you click the "?" icon, it "opens" the help panel right there! EAsy quick access, no need for an extra browser window/ switch screen, show/hide in one click... any drawbacks I didn't notice? ![]()
__________________
joe http://www.eyezberg.com - Flash News |
|
|
| Thread Tools | Search this Thread |
| Display Modes | |
|
|
Similar Threads
|
||||
| Thread | Thread Starter | Forum | Replies | Last Post |
| 4.5.3 - status? | Andyman | Danish Forum | 9 | July 24th, 2005 02:11 |
| Mambo 4.5.3 Template Contest | MamboHut | Templates | 64 | May 19th, 2005 10:55 |
| Version 4.5.3 tendrá TODO traducible | quiquedcode | Spanish Forum | 7 | May 14th, 2005 17:12 |
| Mambo 4.5.3 ???? | vlakonline | Dutch Forum | 1 | March 2nd, 2005 04:07 |
| Mini-roadmap set for 4.5.3 | Michelle Bisson | Documentation Resources | 0 | February 23rd, 2005 08:03 |