Major bug in mambo 5.1a

[Pentarh]

Appearment:
1. when using SEO-type URLs (/component/option,com_rsgallery/ ... etc)
AND
2. when using third-party components (potentially this bug can appear in original modules)

File: MAMBOROOT/includes/sef.php
Function: sefRelToAbs( $string )

Description: This function does URL transformations and it permits non-unique parameter key in URL. I found the following transform result:

http://domain.com/component/option,c.../catid,0/id,1/limitstart,0/limit,1/limitstart,1/

So 'limitstart' variable must have a value of '0', but it was rewrited to '1'. So page navigation did not work.

My fix was:

--- old/sef.php Wed Sep  8 13:24:43 2004
+++ new/sef.php Tue Jan 18 03:31:01 2005
@@ -203,8 +203,15 @@
                        $sefstring = "component/";
                        $temp = split("\?", $string);
                        $temp = split("&", $temp[1]);
+                       $keyvals=array();
+
                        foreach($temp as $key => $value) {
-                               $sefstring .= $value."/";
+                               $keyvalue=explode('=',$value,2);
+                               $keyvals[$keyvalue[0]]=$keyvalue[1];
+                       }
+
+                       foreach($keyvals as $key => $value) {
+                               $sefstring .= $key.'='.$value."/";
                        }
                        $string = str_replace( '=', ',', $sefstring );
                }

PS: I was going to submit this one to mamboforge, but the site was down, so i submitted it here.

PPS: This bug is mostly related to com_rsgallery component, but the fact of non-unique key permittion in original code is a bug also i think.

[Saka]

Hello,

Can you please also post how the corespondent non-sef URL looks like here?

[Pentarh]

Actually i didnt understand your question - my english is not good.

I'll try to describe the situation.

Lets say i have 3rd party component which uses standard pagenavigation tools. Also I use SEO-type URLs = 'On' in global config (URLs like directories and they are without parameters).

So, Before fix my page navigation didnt work in this component. When i click any page number i redirected to 1st page.

Before fix script generated the following URL like:

http://domain.com/component/option,com_rsgallery/page,inline/catid,0/id,1/limitstart,0/limit,1/limitstart,1/

http://domain.com/component/option,com_rsgallery/page,inline/catid,0/id,1/limitstart,0/limit,1/limitstart,2/

You can see that duplicate parameter limitstart is present!

After fix script generated URL:

http://domain.com/component/option,com_rsgallery/page,inline/catid,0/id,1/limit,1/limitstart,1/

http://domain.com/component/option,com_rsgallery/page,inline/catid,0/id,1/limit,1/limitstart,2/

You can see that code above removed first duplicate of limitstart parameter. And page navigation works okay.

[tonyskyday]

He wants you to temporarily disable (turn off) SEF, and post the non-rewritten (non-SEF) URL.

-Tony

[Pentarh]

Got it -thanks. I'll try

[Pentarh]

Okay. I uninstalled patch and turned SEF off.

Pagenavigation works okay, but duplicate parameters are present:

Without patch and SEF=off (works)
to 2nd page: 
option=com_rsgallery&page=inline&catid=0&id=1&limitstart=0&limit=1&limitstart=1
to 3rd page:
option=com_rsgallery&page=inline&catid=0&id=1&limitstart=0&limit=1&limitstart=2

Without patch and SEF=on (dont work page selection. anyway i have 1st page)
to 2nd page: 
/component/option,com_rsgallery/page,inline/catid,0/id,1/limitstart,0/limit,1/limitstart,1/
to 3rd page:
/component/option,com_rsgallery/page,inline/catid,0/id,1/limitstart,0/limit,1/limitstart,2/

With patch and SEF=on (works)
to 2nd page: 
/component/option,com_rsgallery/page,inline/catid,0/id,1/limitstart,1/limit,1/
to 3rd page:
/component/option,com_rsgallery/page,inline/catid,0/id,1/limitstart,2/limit,1/

Actually i understand that the root of this problem is not in SEF function. I dont have time to research this so i putted a stop-code in SEF function to destroy key duplicates in SEO URL.

[Pentarh]

Also there are some other minor fixes and hacks were done. Where can i publish them?

[Saka]

Hello!

Well, as you can see, the problem is in the RSgallery component that has double limitstart argument in the URL.

option=com_rsgallery&page=inline&catid=0&id=1&limitstart=0&limit=1&limitstart=1

The SEF function only converts this URL to the SEF one.

We could, as you suggest, put a check in the SEF function to disable duplicates, but this would actually lead to inconsistency between non-sef and sef URL. We want both these links to give the same result.

You are welcome to put your other fixes here for consideration.

Thanks.