Minor bug with ALL users with sendEmail = 0

[djpushplay]

While fixing another problem, I found a minor bug that occurs when you create a new article from the front end AND every single user has sendEmail turned off (i.e. set to 0 in database).

In other words, if every single user in the database has sendEmail set to 0, there is an error at around line 1396 of content.php because $user is not checked for blank. To fix this minor bug, see the following code:

if ( $isNew ) {
   // messaging for new items
   require_once( $mosConfig_absolute_path .'/components/com_messages/messages.class.php' );

   $database->setQuery( "SELECT id FROM #__users WHERE sendEmail = '1'" );
   $users = $database->loadResultArray();
   if ($users) {   //add this test HERE!
      foreach ($users as $user_id) {
         $msg = new mosMessage( $database );
         $msg->send( $my->id, $user_id, T_("New Item"), sprintf( T_('A new content item has been submitted by [ %s ]  titled [ %s ]  from section [ %s ]  and category  [ %s ]'), $my->username, $row->title, $section, $category ) );
      }
   }   //add this to close the if
}

The 2 lines with "add this" needs to be added to prevent an error from foreach.

Again, this only happens if nobody in the database has sendEmail set to 1 (i.e. everyone has it set to zero). Otherwise, you will never see this problem.

[Keith]

Wow thanks

This will be included in the MamboPro release.

Thank you,
Keith

[djpushplay]

Originally Posted by Keith

Wow thanks

This will be included in the MamboPro release.

Thank you,
Keith

You're welcome. Interesting that nobody had this problem before. I guess everybody must have had sendEmail set to 1, except me.